Update minecraft 1.21 by JackCrumpLeys · Pull Request #675 · valence-rs/valence

JackCrumpLeys · 2024-11-13T20:55:57Z

[moved to chunkedge. Given the owner of Valence not being responsive development has continued off of this fork at chunkedge.]

Update to minecraft 1.21.5

What needs to be done:

dyc3 · 2024-12-01T14:39:42Z

I've noticed most of the changes are simple packet renames. Do you think it would make sense to write a codemod tool to update packet names? Could also be useful for users who are upgrading valence.

Sauronzz · 2024-12-16T14:12:09Z

Is anyone else working on this pr?

JackCrumpLeys · 2024-12-19T05:54:43Z

Is anyone else working on this pr?

Just me at the moment. Feel free to help tho.

maxomatic458 · 2024-12-19T12:48:47Z

@JackCrumpLeys will the 1.21 work be done in this PR or on the next-1.21 branch (on the valence repo)?

Im just gonna assume its here since thats ahead of current master.

JackCrumpLeys · 2024-12-19T19:34:49Z

@JackCrumpLeys will the 1.21 work be done in this PR or on the next-1.21 branch (on the valence repo)?

Im just gonna assume its here since thats ahead of current master.

I plan to split this into smaller prs. Right now I'm just getting all the packets working then I will look into the logic side of things.

olukowski · 2024-12-24T07:38:33Z

Hey, let me know if you want any help with this! Probably gonna use valence for my project, and would like to use the latest version.

JackCrumpLeys · 2025-01-07T23:34:17Z

@Olle-Lukowski

I would love some help. You can help by simply fixing all the compile errors at the moment. then make sure we have all the packets for 1.21.4 (I think we have all the packets for 1.21.3) then I will make sure the complicated ones all encode/decode correctly.

Right now embarrassingly a file is missing (forgot to git-add) so the packets inspector wont compile (I added a feature to see packets that did not encode/decode) I should have that pushed this late afternoon (~6 hours).

dyc3 · 2025-04-03T01:06:40Z

-pub enum IDSet<'a> {
-    NamedSet(Cow<'a, str>),
+pub enum IDSet {
+    NamedSet(String),


Why change this to a String from Cow?

I probably wanted to use ID set in a place where 'a is inappropriate e.g item stack. I honestly don't remember and it can probably be made back into a lifetime.

nicolube · 2025-06-07T23:14:18Z

How is this coming along? I've seen that this PR has been quiet for some time.

maxomatic458 · 2025-06-07T23:20:17Z

@nicolube im working on 2 PRs on https://github.com/JackCrumpLeys/valence/ atm

waiting for a review from @JackCrumpLeys

JackCrumpLeys · 2026-01-08T04:17:56Z

Work has started back up here!

a list of the next steps:

fix:
- respawn logic
- chunk logic
Add new item component stuff to valence_generated
- This means implementing deserialise for the massive ItemComponent struct, unfortunately.
Find a way to test every packet (perhaps fuzz testing using a typed source like prismarinejs?)
Test every packet and implement required fixes
Clean added todo comments and create issues for ones that can't be immediately handled
Review and add comments where necessary

However, I have been working on this for the past five days, almost 10 hours straight each day, so I will be taking a short break to avoid burnout. I am, however, online most of the time and am happy to respond to any questions.

if you wanna be useful checking out the pr and finding yet unknown bugs is very helpful as long as you provide reproducible steps

JackCrumpLeys · 2026-03-28T23:18:08Z

I have marked the PR as ready for review.

The code needs a good look, and I am also interested in any issues with the API and in using anything new. I encourage anyone with projects using Valence to port to this version and share any comments you have.

You can do this by adding this dependency to your Cargo.toml

valence = { git = "https://github.com/JackCrumpLeys/valence", branch = "update-minecraft-1.21", version = "0.2.0-alpha.1" }

dyc3 · 2026-03-28T23:33:41Z

I'm hoping this will be the last merge before we set up a new github org. Since I haven't been involved in a while, I'll defer judgement to the community.

update item_component example + fix some components

fix valence_item export

Fix disconnection when joining with modern player information forwarding

jaapieaapie1 · 2026-04-13T12:54:22Z

+            // TODO: verify command signatures.
+            // As per this gist: https://gist.github.com/kennytv/ed783dd244ca0321bbd882c347892874
+            // It looks like the client only sends the signed version if a command requires
+            // it (in vanilla thats /say for example).


Should create an issue for this when we create the new github org.

jaapieaapie1 · 2026-04-15T13:50:58Z

All the comented out code in this file can just be thrown out imo aslong as the TODO stays there.

jaapieaapie1 · 2026-04-15T13:57:08Z

+
+                // println!("dropping from slot {}", pkt.slot_idx);


This can go

nicolube · 2026-05-02T18:24:34Z

Hello there,

I'm seeing that this this is finaly in this finishing stages, what is the state of this?
I remeber working on component hashing @maxomatic458 did any of that made it into this PR?

maxomatic458 · 2026-05-02T19:56:48Z

I remeber working on component hashing @maxomatic458 did any of that made it into this PR?

Not really. But it turned out to not be required (since its just a complete server side thing), as long as our server side item movement simulation is tracked correctly we never need them anyways.

nicolube · 2026-05-02T21:06:35Z

Not really. But it turned out to not be required (since its just a complete server side thing), as long as our server side item movement simulation is tracked correctly we never need them anyways.

Well, ok, but what this not a server-side feature to prevent inventory-desync? At least I know that we had ghost items for year when having fast inventory interactions.

JackCrumpLeys · 2026-05-03T20:31:38Z

Not really. But it turned out to not be required (since its just a complete server side thing), as long as our server side item movement simulation is tracked correctly we never need them anyways.

Well, ok, but what this not a server-side feature to prevent inventory-desync? At least I know that we had ghost items for year when having fast inventory interactions.

I think that this turned out to be an optimisation we don't need to repeat, and it's more trouble than it's worth. The inventory desync is a separate issue. Nochian clients still manage inventory the same way we already have code for.

jobpaardekooper · 2026-05-04T21:16:53Z

-            registry_codec: Cow::Borrowed(codec.cached_codec()),
-            dimension_type_name: dimension_name.clone(),
-            dimension_name,
+            dimension_name: Ident::new("overworld").unwrap(),


Should this be hard coded like it is?

jobpaardekooper · 2026-05-04T21:18:42Z

 resolver = "2"

 [workspace.package]
 version = "0.2.0-alpha.1+mc.1.20.1"


Should probably be updated, maybe in other places also?

JackCrumpLeys · 2026-06-15T23:18:49Z

It is likely I will close this soon so that work may continue on another repo. I am open to hearing any objections.

maxomatic458 · 2026-06-17T16:15:20Z

@JackCrumpLeys

It is likely I will close this soon so that work may continue on another repo. I am open to hearing any objections.

I have a fix ready for some edge case bug for the item move validation, i think it would be good if we could squeeze that into here before merging.

Ill see if i can make a PR today

This commit is a squash of all commits from the "Update minecraft 1.21" PR on the original Valence report combined with additional final fixes applied later. Please check the links below for the details: valence-rs/valence#675 5b2290a #7 #8 #9 #10 #11 #12 Co-authored-by: Jack Crump-Leys <51773589+JackCrumpLeys@users.noreply.github.com>

This commit is a squash of all commits from the "Update minecraft 1.21" PR on the original Valence report combined with additional final fixes applied later. Please check the links below for the details: valence-rs/valence#675 5b2290a #7 #8 #9 #10 #11 #12 Co-authored-by: Jack Crump-Leys <51773589+JackCrumpLeys@users.noreply.github.com> Co-authored-by: Cheezer1656 <118921295+Cheezer1656@users.noreply.github.com> Co-authored-by: Maxomatic458 <104733404+maxomatic458@users.noreply.github.com> Co-authored-by: Jack Crump-Leys <jackcrumpleys@gmail.com> Co-authored-by: Job Paardekooper <jobpaardekooper@gmail.com> Co-authored-by: SelfMadeSystem <sms@shoghisimon.ca> Co-authored-by: maxomatic458 <maxomatic458@gmail.com> Co-authored-by: SelfMadeSystem <sms@shoghisimon.cc> Co-authored-by: installer <installer@gmail.com> Co-authored-by: Jack crumpleys <jackcrumpleys@gmail.com> Co-authored-by: A.L.I.C.E <20363359+alice39@users.noreply.github.com> Co-authored-by: Lukas Hermansson <lukas@lukashermansson.me>

JackCrumpLeys marked this pull request as draft November 13, 2024 20:56

JackCrumpLeys force-pushed the update-minecraft-1.21 branch from c7bb563 to 1488c18 Compare February 17, 2025 22:08

dyc3 reviewed Apr 3, 2025

View reviewed changes

JackCrumpLeys and others added 17 commits January 16, 2026 17:56

use new registry

d842ea1

push what I have done so far

53db823

some progress

75fa04b

more packet renames to be up to date

a808bde

more packets, the particle packet...

d98436c

more packets

e57aedf

all packets

6a74350

bunch of more progress

aaf4bdd

fixes

f93ae28

fix a test that was not updated with the change from uuid

221f853

bunch of progress

ac7d419

more fixes

3a1d7ec

fixes

ca53a89

skip client packets

494b45b

many fixes

4ae6437

todays work

30e8448

IT COMPILES.

7b5a84b

fix clippy

0919533

JackCrumpLeys marked this pull request as ready for review March 28, 2026 23:12

update type

5ede036

JackCrumpLeys and others added 7 commits March 29, 2026 13:27

Merge pull request #24 from maxomatic458/improve-itemcomponent-example

e3cdbb6

update item_component example + fix some components

fix valence_item export

694ef45

update example

637ec6e

Merge pull request #25 from maxomatic458/fix-valence-item-export

e822b40

fix valence_item export

Fix disconnection when joining with modern player information forwarding

1a70f64

Use old ordering when connection mode isn't Velocity

c024c28

Merge pull request #26 from Cheezer1656/1.21-proxy-fix

bf3d2c5

Fix disconnection when joining with modern player information forwarding

jaapieaapie1 reviewed Apr 13, 2026

View reviewed changes

jaapieaapie1 reviewed Apr 15, 2026

View reviewed changes

jobpaardekooper reviewed May 4, 2026

View reviewed changes

fh-klaus mentioned this pull request Jun 10, 2026

AnvilLevel chunks loading is slow #711

Open

jobpaardekooper mentioned this pull request Jun 14, 2026

Global logger and tracing subscribers are set multiple times in tests #712

Closed

JackCrumpLeys closed this Jun 23, 2026

Uh oh!

Uh oh!

Conversation

JackCrumpLeys commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dyc3 commented Dec 1, 2024

Uh oh!

Sauronzz commented Dec 16, 2024

Uh oh!

JackCrumpLeys commented Dec 19, 2024

Uh oh!

maxomatic458 commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackCrumpLeys commented Dec 19, 2024

Uh oh!

olukowski commented Dec 24, 2024

Uh oh!

JackCrumpLeys commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dyc3 Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

JackCrumpLeys Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

nicolube commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxomatic458 commented Jun 7, 2025

Uh oh!

JackCrumpLeys commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackCrumpLeys commented Mar 28, 2026

Uh oh!

dyc3 commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaapieaapie1 Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

jaapieaapie1 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

jaapieaapie1 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

nicolube commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxomatic458 commented May 2, 2026

Uh oh!

nicolube commented May 2, 2026

Uh oh!

JackCrumpLeys commented May 3, 2026

Uh oh!

jobpaardekooper May 4, 2026

Choose a reason for hiding this comment

Uh oh!

jobpaardekooper May 4, 2026

Choose a reason for hiding this comment

Uh oh!

JackCrumpLeys commented Jun 15, 2026

Uh oh!

maxomatic458 commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

JackCrumpLeys commented Nov 13, 2024 •

edited

Loading

maxomatic458 commented Dec 19, 2024 •

edited

Loading

JackCrumpLeys commented Jan 7, 2025 •

edited

Loading

nicolube commented Jun 7, 2025 •

edited

Loading

JackCrumpLeys commented Jan 8, 2026 •

edited

Loading

dyc3 commented Mar 28, 2026 •

edited

Loading

nicolube commented May 2, 2026 •

edited

Loading